Repository navigation
Conversation
ghfind-review
Bot
added
the
review: medium
Mucheen
changed the title
…ndows-plugin-parity-unified
Connect task and test approval, output and cancellation to the native owner; validate passive Maven model snapshots and queued refreshes. Revoke stale editor attachments and queued text across buffer, workspace and package changes. Cover real WebView lifecycle workflows through the product Quit path.
Connect reviewed Provider model/dependency and page build workflows, workspace test discovery, source-backed plugin settings, transactional project generation, and passive VCS root ownership. Keep rollout gates closed until product acceptance is complete. Retain cleanup owners for Stop retry, preserve framework-specific actions and Core reply data, and repair page refresh cancellation routing. Merge preview d369c9a, classify its new debugger fixtures and make the debug baseline checker resolve Windows file URLs correctly.
Integrate the reviewed R9 changes and preview 32021a8. Preserve typed archive interruptions and staging identity, global settings reload receipts, and isolated VCS session cleanup completion. Validation: 1252 passed / 5 skipped, Windows x64 Release, shared contracts, runtime bundle immutability, Rust documentation, localization and matrix gates.
Integrate reviewed R10 settings functions, generator requirement interactions and segmented forms, and guarded VCS mappings/watch leases. Preserve original owners on late native completion, invalidate stale reviews and release late watcher publication on window destruction. Validation: 1061 passed / 6 skipped, complete TypeScript check, Windows x64 Release, contracts, localization, runtime resource immutability and actual-tree matrix gates.
Route web function requests through the existing Core-owned provider lifecycle, retain exact-window cleanup retries, and retire completed receipts with their native window instance. Add native tree/list/form rendering and Core data validation while keeping ui:3 admission closed. Extend VCS short sessions with read-only history and baseline diffs, cancellation and cleanup recovery. Cover approval/result shapes, form drafts, virtualized controls, deleted and renamed paths, junction escapes and late-owner races. Update fixture coverage, localization, capability evidence and the owning architecture note.
…in-parity-unified
接入原生面板三侧布局、精确关闭与焦点恢复；新增受约束的 VCS resolve/cleanup 及真实 Core stdio 回归。补充设置实包验收驱动、源码身份校验、CI、共享翻译、资源复用规则和功能矩阵。未开放 ui:3/vcsProviders，真实完整包与系统客户端验收继续 pending。
Map all approved host icons to fixed theme resources and reuse a shared accessible InfoTip for disabled fields and actions. Register isolated UI regression suites and record remaining settings runtime and VCS move safety evidence.
Reuse the public input accessory for localized search clearing, preserve native form draft and focus behavior, and register isolated consumer regressions. Complete controlled settings package declarations and installation approval checks, observe frozen Tauri IPC through fetch callbacks, and verify bounded shutdown before resource snapshots. Record real SVN move counterexamples while retaining capability gates and explicit runtime evidence limits. Validation: 946 passed, 5 existing skips; full TypeScript, focused lint/format, shared contracts, stability and platform gates; formal Windows x64 Release.
Correct primary/normal native button variants and cover shared-fixture actions. Verify real WebView2 SearchField default keyboard activation in settings acceptance. Add bounded fixed-input SVN move diagnostics with proven cleanup, path isolation, and failure reporting; wire timed CI reports and resource reuse exclusions. Update owning decisions and partial feature matrices without opening gates.
…back Open the shared context menu for the selected virtual tree row, preserve outside and action-owned focus, and retain expand-button keyboard navigation. Add bounded controlled ui:2 fixture and real WebView2 postMessage fallback acceptance with exact fault injection, identity checks and failure cleanup. Register helper reports and nonreusable resources; document the SVN upstream replacement boundary without opening capability gates.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
主要改动
补齐 Windows 契约插件安装、市场、构建与宿主工作流，并将分阶段交付统一保留在本 PR；基于已合入的 preview 继续保持 Draft 和能力门控。
验证
剩余范围
本地证据：.artifacts/integration-round19/ 与 .artifacts/test-stability/r19-combined.{json,html,junit.xml}；生成报告不提交。原 Cargo.toml、pycache 与主 checkout 改动保留；本轮 owned 进程清理后核对为空。